Set title for single select placeholder - #5973
Merged
Merged
Conversation
This sets the title of the rendered selection for a placeholder when it is displayed within a single select. This is not necessary for a multiple select because the placeholder is set on the search box which will properly convey the value of it and meets ARIA guidelines. Because single select boxes currently use a `textbox` role to convey the keyboard accessibility of the textbox area, and because that role is currently required in ARIA 1.1, it must be properly labelled using the `title`, `aria-label`, or `aria-labelledby` attribute. This currently happens for single selects without a placeholder, and single selects with a placeholder but with an active selection, because the `title` attribute is set to the title of the active selection. Because it only currently sets it for the active selection, this caused an edge case specific to placeholders for single selects where the selection was not properly labelled. The placeholder title follows the same rules for setting the attribute value as for the regular single select selection, except placeholders will also fall back to just using the text value of the placeholder element in the event that the `title` and `text` attributes are not specified on the placeholder data option.
anttikuuskoski
pushed a commit
to anttikuuskoski/select2
that referenced
this pull request
Mar 29, 2022
This sets the title of the rendered selection for a placeholder when it is displayed within a single select. This is not necessary for a multiple select because the placeholder is set on the search box which will properly convey the value of it and meets ARIA guidelines. Because single select boxes currently use a `textbox` role to convey the keyboard accessibility of the textbox area, and because that role is currently required in ARIA 1.1, it must be properly labelled using the `title`, `aria-label`, or `aria-labelledby` attribute. This currently happens for single selects without a placeholder, and single selects with a placeholder but with an active selection, because the `title` attribute is set to the title of the active selection. Because it only currently sets it for the active selection, this caused an edge case specific to placeholders for single selects where the selection was not properly labelled. The placeholder title follows the same rules for setting the attribute value as for the regular single select selection, except placeholders will also fall back to just using the text value of the placeholder element in the event that the `title` and `text` attributes are not specified on the placeholder data option.
maxwellfet928
pushed a commit
to maxwellfet928/select2
that referenced
this pull request
Jun 8, 2026
This sets the title of the rendered selection for a placeholder when it is displayed within a single select. This is not necessary for a multiple select because the placeholder is set on the search box which will properly convey the value of it and meets ARIA guidelines. Because single select boxes currently use a `textbox` role to convey the keyboard accessibility of the textbox area, and because that role is currently required in ARIA 1.1, it must be properly labelled using the `title`, `aria-label`, or `aria-labelledby` attribute. This currently happens for single selects without a placeholder, and single selects with a placeholder but with an active selection, because the `title` attribute is set to the title of the active selection. Because it only currently sets it for the active selection, this caused an edge case specific to placeholders for single selects where the selection was not properly labelled. The placeholder title follows the same rules for setting the attribute value as for the regular single select selection, except placeholders will also fall back to just using the text value of the placeholder element in the event that the `title` and `text` attributes are not specified on the placeholder data option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made
titleattribute for rendered selection in single select when placeholder is visibleIf this is related to an existing ticket, include a link to it as well.
Fixes #5963