Skip to content

Enable GPM - #5660

Merged
kevin-brown merged 5 commits into
developfrom
enable-gpm
Oct 10, 2019
Merged

Enable GPM#5660
kevin-brown merged 5 commits into
developfrom
enable-gpm

Conversation

@kevin-brown

Copy link
Copy Markdown
Member

This pull request includes a

  • Bug fix
  • New feature
  • Translation

The following changes were made

  • Push to GitHub package manager
  • Automatically tag pre-release versions with the commit hash

If this is related to an existing ticket, include a link to it as well.

This is requires in order to deploy to GitHub package manager since
all packages must be scoped to the organization that they are being
deployed to. Because of how publishing scoped packages works with
NPM, there is no easier way to rename a package that is being pushed
to both a scoped and unscoped registry.
There was a change last week that now allows jobs to be filtered
entirely, so this now works like we had originally hoped.
This is needed because you cannot overwrite a version on NPM, so the
previous plan of just using the prelease version would only work for
a single commit.
@kevin-brown
kevin-brown merged commit 7c67f3e into develop Oct 10, 2019
@kevin-brown
kevin-brown deleted the enable-gpm branch October 10, 2019 03:25
maxwellfet928 pushed a commit to maxwellfet928/select2 that referenced this pull request Jun 8, 2026
* Uncomment the deploy_github job for GPR

* Automatically add private scope to package for GPM

This is requires in order to deploy to GitHub package manager since
all packages must be scoped to the organization that they are being
deployed to. Because of how publishing scoped packages works with
NPM, there is no easier way to rename a package that is being pushed
to both a scoped and unscoped registry.

* Don't run NPM deploy if it's not a release

There was a change last week that now allows jobs to be filtered
entirely, so this now works like we had originally hoped.

* Tag branch pushes with commit

This is needed because you cannot overwrite a version on NPM, so the
previous plan of just using the prelease version would only work for
a single commit.

* Fixed invalid version identifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant