This repository was archived by the owner on Jul 3, 2023. It is now read-only.
feat(vpc): Optionally use NAT instances instead of NAT gateways#138
Merged
achille-roussel merged 3 commits intosegmentio:masterfrom Nov 1, 2017
Merged
feat(vpc): Optionally use NAT instances instead of NAT gateways#138achille-roussel merged 3 commits intosegmentio:masterfrom
achille-roussel merged 3 commits intosegmentio:masterfrom
Conversation
Contributor
|
Nope, makes total sense. Thanks both of you guys! |
|
Looks great! |
Contributor
Author
|
Thank you @achille-roussel @calvinfo and @yields - it was a pleasure to add to this module. |
IF NAT instances are used, optional inputs are whether to use Elastic IPs, an SSH key name, and the EC2 instance type. The latest Amazon VPC NAT AMI is used. The use of NAT instances can be less expensive than NAT gateways for development VPCs. NAT instances can be stopped when not in use.
…tances New Amazon NAT AMIs are now ignored - this previously caused NAT instances to be recreated. NAT instances no longer use associate_public_ip_address, as this caused instances which were not using an Elastic IP Address to be recreated if Terraform was run while NAT instances were stopped.
ivanfetch
force-pushed
the
vpc_nat_instances
branch
from
3871a66 to
1debbbf
Compare
Contributor
Author
|
I've committed some fixes to this branch - ignoring new Amazon NAT AMIs, no longer using associate_public_ip_address to avoid recreating NAT instances when they are stopped and not using an Elastic IP, and adding a cidr_block output. |
achille-roussel
approved these changes
Nov 1, 2017
Contributor
achille-roussel
left a comment
achille-roussel
left a comment
There was a problem hiding this comment.
Looks good, thanks for your contributions 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IF NAT instances are used, optional inputs are whether to use Elastic
IPs, an SSH key name, and the EC2 instance type. The latest Amazon VPC
NAT AMI is used. The use of NAT instances can be less expensive than NAT
gateways for development VPCs. NAT instances can be stopped when not in
use.