This repository was archived by the owner on Jul 3, 2023. It is now read-only.
enable tasks to use IAM role#115
Merged
achille-roussel merged 1 commit intosegmentio:masterfrom Jun 22, 2017
Merged
Conversation
Contributor
|
This change is not gonna be enough, the ecs-agent requies some iptables rules to be setup in order to support task roles => https://github.com/aws/amazon-ecs-agent I believe these should be configured at the AMI level, do you think you can tackle this? |
Contributor
Author
|
@achille-roussel aye! |
Contributor
Author
|
@achille-roussel I believe I'll work on that over in #114 |
nathanielks
force-pushed
the
enable-task-role
branch
from
bba3942 to
b63d83f
Compare
Contributor
|
Can you fix the conflict? Than I'll be happy to merge this PR. |
nathanielks
force-pushed
the
enable-task-role
branch
from
b63d83f to
190301b
Compare
Contributor
Author
|
@achille-roussel resolved! |
Contributor
|
Sorry for the delay merging this, thanks for your contribution! |
Contributor
Author
|
No worries at all, @achille-roussel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the
taskmodule to receive aroleproperty. Depends on #114