Skip to content

[Feature] Add new trigger command for scbctl#2570

Merged
J12934 merged 8 commits into
secureCodeBox:mainfrom
Freedisch:trigger
Jul 18, 2024
Merged

[Feature] Add new trigger command for scbctl#2570
J12934 merged 8 commits into
secureCodeBox:mainfrom
Freedisch:trigger

Conversation

@Freedisch

@Freedisch Freedisch commented Jul 11, 2024

Copy link
Copy Markdown
Member

Description

This PR add a new trigger command for scbctl to start scheduledscans
stream issue #189

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@netlify

netlify Bot commented Jul 11, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 36d66ee
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/6698b679ff7acf000809e349

@Freedisch Freedisch changed the title [Feature] Add newtrigger command for sbctl [Feature] Add new trigger command for sbctl Jul 11, 2024
@Weltraumschaf Weltraumschaf added enhancement New feature or request cli Issues regarding the CLI Integration labels Jul 12, 2024
@Freedisch Freedisch marked this pull request as ready for review July 12, 2024 17:34
Freedisch and others added 6 commits July 12, 2024 19:35
@Freedisch
add shell completion for trigger
c8bfd09 
Signed-off-by: freedisch <[email protected]>
@Freedisch
add usage examples
6d4ac4a 
Signed-off-by: freedisch <[email protected]>
@Freedisch
fix failing ci testcases
ce4bdfd 
Signed-off-by: freedisch <[email protected]>
@J12934
Fix / adjust usage description and docs
c334fe1 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Use exact args instead
47515b6 
Trigger doesn't take a variable amount of args, but just one arg

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Use context provided by cobra
36d66ee 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934

J12934 commented Jul 18, 2024

Copy link
Copy Markdown
Member

@Freedisch made some small adjustments / fixes.
Will merge after the CI passes :)

@J12934 J12934 changed the title [Feature] Add new trigger command for sbctl [Feature] Add new trigger command for scbctl Jul 18, 2024
@J12934 J12934 merged commit b36e389 into secureCodeBox:main Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@J12934 J12934 J12934 approved these changes

Assignees

@Freedisch Freedisch

Labels

cli Issues regarding the CLI Integration enhancement New feature or request

Projects

secureCodeBox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Freedisch @J12934 @Weltraumschaf