Skip to content

Fix hostOrIP helper in CascadingScans#1701

Merged
Weltraumschaf merged 18 commits into
mainfrom
bugfix/fix-host-or-ip
Jun 5, 2023
Merged

Fix hostOrIP helper in CascadingScans#1701
Weltraumschaf merged 18 commits into
mainfrom
bugfix/fix-host-or-ip

Conversation

@J12934

@J12934 J12934 commented Apr 21, 2023

Copy link
Copy Markdown
Member

Looking at this mess, i guess the better thing would be to clean this up (by standardizing ips like we did with hostname) before v4?

@J12934 J12934 force-pushed the bugfix/fix-host-or-ip branch from cb61259 to cc70b34 Compare April 21, 2023 19:33
@J12934 J12934 self-assigned this Apr 21, 2023
@github-actions

github-actions Bot commented Apr 21, 2023 •
edited
Loading

Copy link
Copy Markdown

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ JAVASCRIPT eslint 20 1 0.63s
⚠️ SPELL misspell 24 1 0.06s
⚠️ TYPESCRIPT eslint 4 1 0.36s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@secureCodeBox secureCodeBox deleted a comment from github-actions Bot Apr 21, 2023
Ilyesbdlala
Ilyesbdlala previously approved these changes Apr 25, 2023
View reviewed changes

@Ilyesbdlala Ilyesbdlala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from a small suggestion.

Comment thread hooks/cascading-scans/hook/hook.ts Outdated
@J12934 J12934 force-pushed the bugfix/fix-host-or-ip branch from cc70b34 to 1ab5d31 Compare May 23, 2023 19:11
@J12934 J12934 force-pushed the bugfix/fix-host-or-ip branch from 13b7494 to 95f6eb3 Compare June 2, 2023 08:31
J12934 and others added 18 commits June 2, 2023 11:25
@J12934
Auto format cascading-hook
ab0d517 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Ensure that hostOrIp works with all formats
63a4fb0 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Add ip_addresses field to amass
1709ed8
@J12934
Add ip_addresses to A & AAAA records identified by doggo
dd6d68e
@J12934
Autoformat ncrack parser
254996a
@J12934
Convert ip_address field in ncrack to an array
ee6eb28
@J12934
Format nikto parser
9912d46
@J12934
Convert ip_address field in nikto to an array
4163ccb
@J12934
Convert ip_address field in nuclei to an array
cc36a66
@J12934
Format semgrep parser
6f76a72
@J12934
Convert ip_address field in ssh-audit to an array
1ce7324
@J12934
Convert ip_address field in sslyze to an array
9c6b9ca
@J12934
Convert ip_address field in test-scan to an array
5330b91
@J12934
Format typo3 parser
f002911
@J12934
Convert ip_address field in whatweb to an array
1b1903d
@J12934
Convert ip_address field in wpscan to an array
26b9395
@J12934
Migrate cascading hook to use new unified ip_addresses field
97e7d08
@J12934
Update upgrading notes with notes for each scanner
a72b7e4
@J12934 J12934 force-pushed the bugfix/fix-host-or-ip branch from 95f6eb3 to a72b7e4 Compare June 2, 2023 09:25
@Ilyesbdlala

Ilyesbdlala commented Jun 3, 2023

Copy link
Copy Markdown
Member

LGTM. But some scanners use NULL as a value for empty ip_adresses and some use undefined. AFAIK, it's better to use NULL. At least that's what I used here #1676

@Weltraumschaf Weltraumschaf merged commit 58983fb into main Jun 5, 2023
@Weltraumschaf Weltraumschaf deleted the bugfix/fix-host-or-ip branch June 5, 2023 11:01
@Weltraumschaf

Weltraumschaf commented Jun 5, 2023

Copy link
Copy Markdown
Member

LGTM. But some scanners use NULL as a value for empty ip_adresses and some use undefined. AFAIK, it's better to use NULL. At least that's what I used here #1676

I suggest to open a new PR for that, in hope we have more small short lived PRs 😬

J12934 added a commit that referenced this pull request Jun 5, 2023
@J12934
Use empty array for findings where no ips were identified
a0f4925 
Followup for #1701
J12934 added a commit that referenced this pull request Jun 5, 2023
@J12934
Use empty array for findings where no ips were identified
baf1cdf 
Followup for #1701

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934 J12934 mentioned this pull request Jun 5, 2023
Merged
3 tasks
J12934 added a commit that referenced this pull request Jun 5, 2023
@J12934
Use empty array for findings where no ips were identified
9d2f6e5 
Followup for #1701

Signed-off-by: Jannik Hollenbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rfelber rfelber rfelber approved these changes

@Ilyesbdlala Ilyesbdlala Ilyesbdlala left review comments

Assignees

@J12934 J12934

Labels

bug Bugs cascading-scans

Projects

secureCodeBox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@J12934 @Ilyesbdlala @Weltraumschaf @rfelber