Added optional mitigation attribute to findings#1639
Merged
Conversation
Contributor
|
This pull request includes breaking changes. Please make sure that you included the breaking changes and the steps required to upgrade in UPGRADING.md. |
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| eslint | 9 | 1 | 0.57s | ||
| ✅ JSON | eslint-plugin-jsonc | 1 | 0 | 1.04s | |
| misspell | 10 | 1 | 0.06s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
Ilyesbdlala
force-pushed
the
feature/mitigation-attribute
branch
from
2c07f0e to
855c47e
Compare
J12934
requested changes
Mar 17, 2023
J12934
left a comment
J12934
left a comment
Member
There was a problem hiding this comment.
Looking good, some really minor notes then it should be ready to go 🚀
J12934
previously approved these changes
Mar 20, 2023
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
…nt` to `mitigation` Signed-off-by: Ilyes Ben Dlala <[email protected]>
…` to `mitigation` Signed-off-by: Ilyes Ben Dlala <[email protected]>
…sing the zap_solution attribute Signed-off-by: Ilyes Ben Dlala <[email protected]>
Linked to Advisory URL Signed-off-by: Ilyes Ben Dlala <[email protected]>
…` in the v4 section of UPGRADING.MD Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Co-authored-by: Jannik Hollenbach <[email protected]> Signed-off-by: Ilyes Ben Dlala <[email protected]>
Co-authored-by: Jannik Hollenbach <[email protected]> Signed-off-by: Ilyes Ben Dlala <[email protected]>
mitigation "" to null when empty Signed-off-by: Ilyes Ben Dlala <[email protected]>
Ilyesbdlala
force-pushed
the
feature/mitigation-attribute
branch
from
a96a5dd to
1b03bca
Compare
J12934
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relates to #519
The attribute
mitigationis added to scanners who include explicit solution in their results or where the solution is almost always the same (i.e ncrack -> use a more secure password)Scanners that are usually informational (such as NMAP) are excluded.
Scanners affected:
Checklist