#1894 Remove unused functions and k8s permissions

Lukas Fischer · Lukas Fischer · commit e63bfaaee3e6 · 2023-10-20T12:57:16.000+02:00
The initial set of kubernetes permissions for the role in the helm
template was adapted from the kubernetes AutoDiscovery, which is based
on kubebuilder. The AWS Cloud AutoDiscovery manually connects to
kubernetes and uses a lot fewer API permissions than the kubernetes
AutoDiscovery. If future features need more permissions they can be
added back again.

Signed-off-by: Lukas Fischer &lt;lukas.fischer@iteratec.com&gt;
diff --git a/auto-discovery/cloud-aws/pkg/kubernetes/kubernetes.go b/auto-discovery/cloud-aws/pkg/kubernetes/kubernetes.go
@@ -17,7 +17,6 @@ import (
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
-	"k8s.io/apimachinery/pkg/types"
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 	"k8s.io/cli-runtime/pkg/genericclioptions"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -185,18 +184,6 @@ func (r *CloudScanReconciler) handleDeleteRequest(ctx context.Context, req Reque
 	return err
 }
 
-func (r *CloudScanReconciler) getScheduledScan(ctx context.Context, name string) (*executionv1.ScheduledScan, error) {
-	scheduledScan := &executionv1.ScheduledScan{}
-	err := r.Client.Get(ctx, types.NamespacedName{Name: name, Namespace: r.Config.Kubernetes.Namespace}, scheduledScan)
-	return scheduledScan, err
-}
-
-func (r *CloudScanReconciler) listScheduledScans(ctx context.Context) (*executionv1.ScheduledScanList, error) {
-	var scheduledscans executionv1.ScheduledScanList
-	err := r.Client.List(ctx, &scheduledscans, client.InNamespace(r.Config.Kubernetes.Namespace))
-	return &scheduledscans, err
-}
-
 func (r *CloudScanReconciler) createScheduledScan(ctx context.Context, scheduledScan *executionv1.ScheduledScan) (*executionv1.ScheduledScan, error) {
 	scheduledScan.ObjectMeta.Namespace = r.Config.Kubernetes.Namespace
 	err := r.Client.Create(ctx, scheduledScan)
diff --git a/auto-discovery/cloud-aws/templates/rbac/role.yaml b/auto-discovery/cloud-aws/templates/rbac/role.yaml
@@ -8,51 +8,10 @@ kind: Role
 metadata:
   name: auto-discovery-cloud-aws
 rules:
-- apiGroups:
-  - execution.securecodebox.io
-  resources:
-  - scantypes
-  verbs:
-  - get
-  - list
-  - watch
 - apiGroups:
   - execution.securecodebox.io
   resources:
   - scheduledscans
   verbs:
   - create
-  - get
-  - list
-  - patch
-  - update
-  - watch
   - delete
-- apiGroups:
-  - execution.securecodebox.io/status
-  resources:
-  - scheduledscans
-  verbs:
-  - get
-  - patch
-  - update
-- apiGroups:
-  - execution.securecodebox.io
-  resources:
-  - scans
-  verbs:
-  - create
-  - get
-  - list
-  - patch
-  - update
-  - watch
-  - delete
-- apiGroups:
-  - execution.securecodebox.io/status
-  resources:
-  - scans
-  verbs:
-  - get
-  - patch
-  - update
