Skip to content

Bugfixes Fun mooc #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
floviolleau wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfixes Fun mooc #603

floviolleau wants to merge 2 commits into from

Conversation

@floviolleau
Copy link

@floviolleau floviolleau commented Apr 20, 2020

Proposed changes

Make Fun Mooc download working.

Fix issues #573 and #531 and add quality selection with -q or --quality parameter (default to 720p)

Types of changes

What types of changes does your code introduce?

  • [ X] Bugfix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [X ] I have read the CONTRIBUTING doc
  • [ X] I agree to contribute my changes under the project's LICENSE
  • I have checked that the unit tests pass locally with my changes
  • [ X] I have checked the style of the new code (lint/pep).
  • I have added tests that prove my fix is effective or that my feature works
  • [ X] I have added necessary documentation (if appropriate)

Further comments

Reviewers

If you know the person who can review your code please add a @mention.
@balta2ar ?

@floviolleau floviolleau mentioned this pull request Jul 8, 2020
Open
@floviolleau
Copy link
Author

floviolleau commented Jul 8, 2020

Hi @rbrito,

Can you please merge this PR?

Thanks

@floviolleau
Copy link
Author

floviolleau commented Aug 10, 2020

Hi,

After 1 month, someone can merge the PR?

Thanks in advance

@floviolleau
Copy link
Author

floviolleau commented Jun 25, 2021

Hi @balta2ar,

I see that you are the top contributor on this project and I'm tagging you to understand if this project is still maintened.

Thanks in advance for your answer

@balta2ar
Copy link
Member

balta2ar commented Jun 25, 2021

Not really, I don't personally use this script anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@floviolleau @balta2ar