Overcommit should error when environment variables are not strings #423
Description
When env variable value is a boolean...
PrePush:
RSpec:
enabled: true
quiet: false
description: 'Run RSpec test suite'
env:
CODE_COVERAGE: true
command: ['bundle', 'exec', 'rspec', 'spec', '--tag', '~type:request']Overcommit blows up.
$ git push
Running pre-push hooks
Run RSpec test suite..........................................[RSpec] FAILED
Hook raised unexpected error
no implicit conversion of true into StringWhen env variable is string...
PrePush:
RSpec:
enabled: true
quiet: false
description: 'Run RSpec test suite'
env:
CODE_COVERAGE: 'truthy' # why does this have to be a string?
command: ['bundle', 'exec', 'rspec', 'spec', '--tag', '~type:request']Overcommit works with no issues.
Am I missing something or does overcommit depend on having a string?