Declare a requirement on ext-mbstring instead of requiring the polyfill - #833
Merged
Conversation
Thanks to the `provide` rule in the `symfony/polyfill-mbstring` package, it is still possible for projects to install that polyfill to satisfy the `ext-mbstring` requirement. Our code uses the mbstring API but never checks whether the extension is loaded, so that the polyfill can be used to provide that API.
Member
Author
|
@Cerdic when updating the vendored dependencies in your SPIP plugin to use scssphp 2.1+, you should decide whether you vendor the polyfill or require the extension (vendoring the polyfill will be a matter of adding it in your composer.json in the vendoring setup) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to the
providerule in thesymfony/polyfill-mbstringpackage, it is still possible for projects to install that polyfill to satisfy theext-mbstringrequirement.Our code uses the mbstring API but never checks whether the extension is loaded, so that the polyfill can be used to provide that API.
This optimizes the experience for setups that have mbstring available rather than for setups that want to rely on the (slow) polyfill.
This allows me to remove the CI job actually using the polyfill to run, requiring hacks due to PHPUnit not supporting the polyfill in newer versions.