Query as API - #165
Open
breadchris wants to merge 7 commits into
Open
Conversation
poundifdef
reviewed
Apr 17, 2024
| Destination Destination `gorm:"constraint:OnDelete:CASCADE"` | ||
| HashedAPIKey string `gorm:"index"` | ||
| // If the API key is specific to a saved query | ||
| SavedQueryID uint |
Contributor
There was a problem hiding this comment.
One comment here (I realize this is copied from my existing branch.) I'd started to refactor this so that the APIKey table does not have a SavedQuery, and instead use a Join table, ie, apikey_savedquery. Then I just added an APIKey "type" (QUERY, GENERAL - or something more descriptive) that tells me about who the key belongs to.
This also then lets me create a single API key and give it access to multiple endpoints. And it didn't make sense the QueryParams be in this table either since it's such a specific use case.
breadchris
marked this pull request as ready for review
April 19, 2024 17:30
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #164