Updates Dockerfile to fix docker build, adds .dockerignore file and updates the readme with instructions for docker - #162
Conversation
|
I realized I should caveat this PR slightly -- I am not a golang-native developer. You should review this code critically in that light, as though I am a junior developer who doesn't even know the ways in which this PR could be wrong. It is very possible that I am missing something obvious about which folders should be hoisted from the code repository into the Dockerfile working directory prior to the the call to |
This comment was marked as outdated.
This comment was marked as outdated.
|
Added .dockerignore file (same as the .gitignore file), and added a section in the readme on how to build and run a container using |
|
Looks good! I'll give it a test and merge when I confirm. Appreciate your iterating on this :) |
Please let me know if this solution is unworkable for some reason, or if you need a CLA or something from me.