Skip to content

Updates Dockerfile to fix docker build, adds .dockerignore file and updates the readme with instructions for docker - #162

Open
NortySpock wants to merge 4 commits into
scratchdata:mainfrom
NortySpock:feature/update-developer-dockerfile
Open

Updates Dockerfile to fix docker build, adds .dockerignore file and updates the readme with instructions for docker#162
NortySpock wants to merge 4 commits into
scratchdata:mainfrom
NortySpock:feature/update-developer-dockerfile

Conversation

@NortySpock

Copy link
Copy Markdown

Please let me know if this solution is unworkable for some reason, or if you need a CLA or something from me.

@NortySpock

NortySpock commented Apr 18, 2024

Copy link
Copy Markdown
Author

I realized I should caveat this PR slightly -- I am not a golang-native developer. You should review this code critically in that light, as though I am a junior developer who doesn't even know the ways in which this PR could be wrong.

It is very possible that I am missing something obvious about which folders should be hoisted from the code repository into the Dockerfile working directory prior to the the call to go mod download and go build -o scratchdata. For instance, I did not copy in the /models or /pkg folder when I was drafting this PR yesterday, because it appeared to work without them. However, reading though the import section of main.go this evening, I realize I probably should at least copy in the /pkg folder, otherwise a developer working on the code later might wonder why their changes in the /pkg/ folder are not having any effect.

@NortySpock

This comment was marked as outdated.

Comment thread Dockerfile
Comment thread docker-compose.yml Outdated
@NortySpock NortySpock changed the title Updates Dockerfile to fix docker build, adds docker-compose file Updates Dockerfile to fix docker build, adds .dockerignore file and updates the readme with instructions for docker Apr 19, 2024
@NortySpock
NortySpock requested a review from breadchris April 19, 2024 19:04
@NortySpock

NortySpock commented Apr 19, 2024

Copy link
Copy Markdown
Author

Added .dockerignore file (same as the .gitignore file), and added a section in the readme on how to build and run a container using docker run.

@poundifdef

Copy link
Copy Markdown
Contributor

Looks good! I'll give it a test and merge when I confirm. Appreciate your iterating on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants