fix: pass atol, rtol and equal_nan as kwargs to awkward's isclose method#658
Merged
pfackeldey merged 2 commits intoscikit-hep:mainfrom Nov 3, 2025
Merged
Conversation
…s in `isclose` method
pfackeldey
requested changes
Oct 30, 2025
Collaborator
pfackeldey
left a comment
pfackeldey
left a comment
There was a problem hiding this comment.
Thanks @mrzimu, looks good to me! 🎉
I have only one request: could you move the test functions into this file https://github.com/scikit-hep/vector/blob/main/tests/test_issues.py? It's a dedicated test file that contains test for issues opened in GitHub and the test function name contains the issue number. In your case that would be def test_issue_657():. This lets us track down the test to the issue in the future :)
Saransh-cpp
approved these changes
Nov 1, 2025
Member
Saransh-cpp
left a comment
Saransh-cpp
left a comment
There was a problem hiding this comment.
Thanks, @mrzimu! This looks great! @pfackeldey please feel free to merge once you approve ✅
pfackeldey
approved these changes
Nov 3, 2025
Collaborator
pfackeldey
left a comment
pfackeldey
left a comment
There was a problem hiding this comment.
LGTM! thanks @mrzimu for the PR and @Saransh-cpp for the review 🎉 I'll merge this one 👍
Contributor
Author
|
Yeah, happy to see this helps :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi,
This PR fixes #657, not only for
Vector3D, but also 2D and lorentz vector. I also added a test for this.Checklist
$ pre-commit run --all-filesor$ nox -s lint)$ pytestor$ nox -s tests)$ cd docs; make clean; make htmlor$ nox -s docs)$ pytest --doctest-plus src/vector/or$ nox -s doctests)Before Merging