Match setuptools behavior for include_package_data default.#873
Merged
henryiii merged 4 commits intoscikit-build:mainfrom Mar 2, 2023
Merged
Match setuptools behavior for include_package_data default.#873henryiii merged 4 commits intoscikit-build:mainfrom
henryiii merged 4 commits intoscikit-build:mainfrom
Conversation
henryiii
reviewed
Feb 28, 2023
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
864-tools-documentation
branch
from
14584d8 to
750d70f
Compare
Contributor
Author
|
Thanks for making the change to use tomli/tomllib instead of manual text parsing! As you noted I wasn't sure if you wanted to introduce the dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to match the default behavior of
include_package_datain setuptools, which is somewhat subtle in that the default is dependent on the existence of certain tables in pyproject.toml.Resolves #864.