Conversation
|
With e000bd7, we can also close scijava/scijava#64 |
|
Over in scijava/scijava#13, @ctrueden said:
With this PR, you'd do something like the following: var theExistingLogger = Logging.getLogger();
Logging.setLogger(myVeryVerboseLogger);
ops.op("some op I want to debug").arityX().inputs(...).apply();
Logging.setLogger(theExistingLogger);What would you prefer? Something like: var op = ops.op("some op I want to debug").arityX().inputs(...).function();
Logging.setLogger(op, myVeryVerboseLogger);
op.apply(...)I don't feel too strongly one way or the other - honestly, it wouldn't be too terribly hard to add the other, if that's what you think people will use.
This seems like something that the
Isn't this basically what we're doing now? |
c386f6d to
08218bc
Compare
|
Discussion in scijava/scijava#13 looks unresolved. I'm going to move this to a draft PR and remove the reviewers for the moment until we have a chance to discuss further. |
11a45b5 to
453608a
Compare
453608a to
afb9e08
Compare
We aren't using it anymore, but we can bring it back later if needed
This prevents us from having to pass a Logger around everywhere!
In addition, I noticed that the
LoggerandOpMonitorutility classes were still hanging around in the engine, so I removed them!Closes scijava/scijava#106, scijava/scijava#13 and maybe other issues.