Skip to content

quics: comment here #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-github wants to merge 3 commits into from
Closed

quics: comment here #6

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2350cdf
quic: initial quic implementation
jasnell Mar 9, 2020
e7b25da
quic: fixup test-fs-chown
jasnell Mar 12, 2020
928c50e
quic: fixup broken test when quic unavailable
jasnell Mar 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quic: fixup test-fs-chown 
PR-URL: nodejs/quic#360
Reviewed-By: Anna Henningsen <[email protected]>
  • Loading branch information
@jasnell
jasnell committed Mar 13, 2020
commit e7b25da6a8ce654699896c14026e53b8717b6470
24 changes: 12 additions & 12 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,26 +1154,26 @@ function chmodSync(path, mode) {
function lchown(path, uid, gid, callback) {
callback = makeCallback(callback);
path = getValidatedPath(path);
validateInteger(uid, 'uid', -1, kMaxUserId);
validateInteger(gid, 'gid', -1, kMaxUserId);
validateInteger(uid, 'uid', { min: -1, max: kMaxUserId });
validateInteger(gid, 'gid', { min: -1, max: kMaxUserId });
const req = new FSReqCallback();
req.oncomplete = callback;
binding.lchown(pathModule.toNamespacedPath(path), uid, gid, req);
}

function lchownSync(path, uid, gid) {
path = getValidatedPath(path);
validateInteger(uid, 'uid', -1, kMaxUserId);
validateInteger(gid, 'gid', -1, kMaxUserId);
validateInteger(uid, 'uid', { min: -1, max: kMaxUserId });
validateInteger(gid, 'gid', { min: -1, max: kMaxUserId });
const ctx = { path };
binding.lchown(pathModule.toNamespacedPath(path), uid, gid, undefined, ctx);
handleErrorFromBinding(ctx);
}

function fchown(fd, uid, gid, callback) {
validateInt32(fd, 'fd', 0);
validateInteger(uid, 'uid', -1, kMaxUserId);
validateInteger(gid, 'gid', -1, kMaxUserId);
validateInteger(uid, 'uid', { min: -1, max: kMaxUserId });
validateInteger(gid, 'gid', { min: -1, max: kMaxUserId });

const req = new FSReqCallback();
req.oncomplete = makeCallback(callback);
Expand All @@ -1182,8 +1182,8 @@ function fchown(fd, uid, gid, callback) {

function fchownSync(fd, uid, gid) {
validateInt32(fd, 'fd', 0);
validateInteger(uid, 'uid', -1, kMaxUserId);
validateInteger(gid, 'gid', -1, kMaxUserId);
validateInteger(uid, 'uid', { min: -1, max: kMaxUserId });
validateInteger(gid, 'gid', { min: -1, max: kMaxUserId });

const ctx = {};
binding.fchown(fd, uid, gid, undefined, ctx);
Expand All @@ -1193,8 +1193,8 @@ function fchownSync(fd, uid, gid) {
function chown(path, uid, gid, callback) {
callback = makeCallback(callback);
path = getValidatedPath(path);
validateInteger(uid, 'uid', -1, kMaxUserId);
validateInteger(gid, 'gid', -1, kMaxUserId);
validateInteger(uid, 'uid', { min: -1, max: kMaxUserId });
validateInteger(gid, 'gid', { min: -1, max: kMaxUserId });

const req = new FSReqCallback();
req.oncomplete = callback;
Expand All @@ -1203,8 +1203,8 @@ function chown(path, uid, gid, callback) {

function chownSync(path, uid, gid) {
path = getValidatedPath(path);
validateInteger(uid, 'uid', -1, kMaxUserId);
validateInteger(gid, 'gid', -1, kMaxUserId);
validateInteger(uid, 'uid', { min: -1, max: kMaxUserId });
validateInteger(gid, 'gid', { min: -1, max: kMaxUserId });
const ctx = { path };
binding.chown(pathModule.toNamespacedPath(path), uid, gid, undefined, ctx);
handleErrorFromBinding(ctx);
Expand Down