Add LimitedString field with min/max constraints and automatic validation#18769
Draft
lkostrowski wants to merge 5 commits intomainfrom
Draft
Add LimitedString field with min/max constraints and automatic validation#18769lkostrowski wants to merge 5 commits intomainfrom
lkostrowski wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LimitedString()— a factory function that createsgraphene.Stringfields withmin_length/max_lengthconstraints. Constraint metadata is stored on the field and automatically propagated toBaseInputObjectTypesubclasses via_string_constraints.BaseMutation.mutate()andDeprecatedModelMutationthat recursively validates allLimitedStringconstraints beforeperform_mutationruns — no manual validation needed in individual mutations."(maximum 250 characters.)")altfield (max 250)name(max 256),brand(max 40),firstDigits/lastDigits(max 4), other payment methodname(max 256)message(max 255)Test plan
LimitedStringfield factory (constraints, descriptions, assertions)BaseInputObjectType._string_constraintspropagation and inheritancevalidate_string_constraintsvalidatorBaseMutation._validate_input_string_constraints(recursive, nested, list)🤖 Generated with Claude Code