docs(recipes): Fix mini.icons + lspkind recipe#2148
Merged
Conversation
Owner
|
I believe I got the same behavior but managed to simplify it a bit. Lmk if I broke anything though and I'll fix it up on main. Sorry for the wait! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #2121:
The issue is that icons related to filesystem types (like
link,socket,fifo, etc.) don’t exist inmini.icons. With this PR, those types are assigned the default"os"icon (a desktop computer), since I couldn’t find a better fit for filesystem-related items.I am aware that the code pattern repeats twice, but I kept it that way because I felt an external function wouldn’t fit well with the general structure of the “recipes".