fix: use Valuelength for parseString instead of whole String size#96
Merged
Conversation
If a resource has a empty string, parsing value of string is parsed incorrectly(getting a next String part as string). As String.ValueLength is length in utf-16 string without null value, use 2*(s.ValueLength+1).
Snshadow
changed the title
Member
|
Hello @Snshadow Sorry for my late reply but great catch ! Do you have a test sample or a hash to test this ? would be nice to add a test for this one or just provide me a hash and I can add it. Cheers. |
Contributor
Author
|
I added the sample file in test directory and test case in version_test.go, and the test passes with the fixed code. |
Member
|
Beautiful ! LGMT, merging it now, I will push a new tag now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a resource has a empty string, parsing value of string is parsed incorrectly(getting a next String part as string).
As String.ValueLength is length in utf-16 string without null value, use 2*(s.ValueLength+1) instead.