Remove pointers from main PE struct#44
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 62.19% 62.13% -0.06%
==========================================
Files 25 25
Lines 4452 4445 -7
==========================================
- Hits 2769 2762 -7
Misses 1411 1411
Partials 272 272
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Filestructure has many pointer to struct fields. The reason why I put those fields as pointers is not to save some memory or because I needed the structs to be modified by some method, it was only yo make it easier when JSON marshaling so we can omit the empty structs because they contain NULL value.This PR get rid of those pointers as the library should not be biased to any specific use case.
This should not break the APIs.