Added ParseVersionResourcesForEntries to support files with multiple product versions.#105
Merged
ayoubfaouzi merged 1 commit intoNov 12, 2024
Conversation
…product versions.
Member
|
Thanks @getvictor ! LGTM, as long as test passes. If you have a small binary we can test with, it will be awesome. Otherwise, I will dig my collection of file to find one. |
Member
|
|
Member
|
Your feature has been included in the last tag: v1.5.5. Cheers mate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A self-extracting archive like https://get.opera.com/ftp/pub/opera/desktop/114.0.5282.94/win/Opera_114.0.5282.94_Autoupdate_x64.exe contains the product versions for 7-Zip and the actual application.
This PR adds the
ParseVersionResourcesForEntriesmethod, which returns these separate product versions as a slice. This allows us to separate the 7-Zip version from the Opera version.ParseVersionResourceshas been refactored for code reuse.