fix: improve AppImage icon extraction and selection - #1
Open
johnny-bit wants to merge 1 commit into
Open
Conversation
Large AppImages (500+ embedded icons) caused the installer to exit silently after "Extracting icon..." because find|sort|head triggered SIGPIPE under set -o pipefail. Search icons in spec order instead of picking the first file in the tree: .DirIcon and root desktop Icon= (AppDir/AppImage), then the best hicolor icon under share/icons, then any png/svg as last resort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large AppImages (500+ embedded icons) caused the installer to exit silently after "Extracting icon..." because find|sort|head triggered SIGPIPE under set -o pipefail.
Search icons in spec order instead of picking the first file in the tree: .DirIcon and root desktop Icon= (AppDir/AppImage), then the best hicolor icon under share/icons, then any png/svg as last resort.