Added classes for testing API with Jackson by rusakov66 · Pull Request #5 · rusakov66/API_testing

rusakov66 · 2019-06-25T18:57:26Z

First code with Jackson. Nogami ne beite

vboaghe · 2019-06-27T08:44:49Z

@@ -0,0 +1,34 @@
+public class ApiStructure {


rename to User

vboaghe · 2019-06-27T08:45:11Z

@@ -0,0 +1,34 @@
+public class ApiStructure {
+    public String login = "rusakov6699";
+    public long id = 16705398;


all fields -> private (use getters)

vboaghe · 2019-06-27T08:45:30Z

+    public String login = "rusakov6699";
+    public long id = 16705398;
+    public String node_id = "MDQ6VXNlcjE2NzA1Mzk4";
+    public String avatar_url = "https://avatars1.githubusercontent.com/u/16705398?v=4";


no need to assign a value to this fields

Were removed

vboaghe · 2019-06-27T08:46:50Z

+import static org.hamcrest.core.IsNull.notNullValue;
+import static org.junit.jupiter.api.Assertions.assertAll;
+
+public class ApiTestWithJackson {


rename (e.g GetUserJacksonTest)

vboaghe · 2019-06-27T08:47:48Z

+    @Test
+    public void getRequestFromGithubTest() throws IOException {
+        ObjectMapper mapper = new ObjectMapper();
+        String stringURL = "https://api.github.com/users/rusakov66";


extract as a constant

vboaghe · 2019-06-27T08:48:18Z

+        String stringURL = "https://api.github.com/users/rusakov66";
+        Response response = get(stringURL);
+        JSONObject jsonResponse = new JSONObject(response.asString());
+        System.out.println(jsonResponse);


we repeated 100 times about system.out

Sorry for SOP's - there were my debugging points ....

vboaghe · 2019-06-27T08:48:30Z

+        System.out.println(jsonResponse);
+        ObjectMapper objectMapper = new ObjectMapper();
+        String jsonResponseAsString = jsonResponse.toString();
+        System.out.println(jsonResponseAsString);


we repeated 100 times about system.out

vboaghe · 2019-06-27T08:48:56Z

+        String jsonResponseAsString = jsonResponse.toString();
+        System.out.println(jsonResponseAsString);
+        ApiStructure jsonResponseAsObject = objectMapper.readValue(jsonResponseAsString, ApiStructure.class);
+        String statusLine = response.getStatusLine();


not statusLine, but StatusCode

vboaghe · 2019-06-27T08:49:00Z

+        System.out.println(jsonResponseAsString);
+        ApiStructure jsonResponseAsObject = objectMapper.readValue(jsonResponseAsString, ApiStructure.class);
+        String statusLine = response.getStatusLine();
+        System.out.println("statusLine" + statusLine);


we repeated 100 times about system.out

vboaghe · 2019-06-27T08:50:22Z

+        String statusLine = response.getStatusLine();
+        System.out.println("statusLine" + statusLine);
+        assertAll(
+                () -> assertThat(jsonResponseAsObject.login, is("rusakov667")),


jsonResponseAsObject - it is not json.
rename

vboaghe · 2019-06-27T08:51:43Z

+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-databind</artifactId>
+            <version>2.9.8</version>


version to a property

rusakov66 force-pushed the Jackson branch 2 times, most recently from bbaca89 to 2296d2d Compare June 27, 2019 08:23

vboaghe reviewed Jun 27, 2019

View reviewed changes

rusakov66 force-pushed the Jackson branch from 2296d2d to 9c7cd01 Compare June 28, 2019 07:20

Added classes for testing API with Jackson

fd3bb25

rusakov66 force-pushed the Jackson branch from 9c7cd01 to fd3bb25 Compare June 28, 2019 07:58

Conversation

rusakov66 commented Jun 25, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants