Skip to content

fix: update test script to work without lsof on CI #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrvb-rl merged 2 commits into from
Jun 26, 2026
+35 −2
Merged

fix: update test script to work without lsof on CI #798

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44887e9
Fix test script to work without lsof on CI
jrvb-rl May 8, 2026
d568641
Add /proc fallback for finding processes on a port
jrvb-rl May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions scripts/test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,43 @@ function steady_is_running() {
curl --silent "http://127.0.0.1:4010/_x-steady/health" >/dev/null 2>&1
}

find_pids_on_port_via_proc() {
# Parse /proc/net/tcp{,6} to find socket inodes listening on the port,
# then scan /proc/*/fd/ to find which pids own those sockets.
local port_hex
port_hex=$(printf '%04X' "$1")
local inodes
inodes=$(awk -v ph="$port_hex" '$2 ~ ":"ph"$" && $4 == "0A" {print $10}' /proc/net/tcp /proc/net/tcp6 2>/dev/null | sort -u)
[ -z "$inodes" ] && return
local pids=""
for inode in $inodes; do
for fd in /proc/[0-9]*/fd/*; do
if [ "$(readlink "$fd" 2>/dev/null)" = "socket:[$inode]" ]; then
local pid="${fd#/proc/}"
pid="${pid%%/fd/*}"
pids="$pids $pid"
break
fi
done
done
echo "$pids" | xargs
}

kill_server_on_port() {
pids=$(lsof -t -i tcp:"$1" || echo "")
if command -v lsof >/dev/null 2>&1; then
pids=$(lsof -t -i tcp:"$1" || echo "")
elif command -v ss >/dev/null 2>&1; then
pids=$(ss -tlnp "sport = :$1" 2>/dev/null | grep -oP 'pid=\K[0-9]+' || echo "")
elif command -v fuser >/dev/null 2>&1; then
pids=$(fuser "$1/tcp" 2>/dev/null || echo "")
elif [ -d /proc/net ]; then
pids=$(find_pids_on_port_via_proc "$1")

@james-rl james-rl Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just do this?

@jrvb-rl jrvb-rl Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it was helpful to just try all of the reasonable things, to reduce the chances of this breaking in the future in different environments. Eg, the /proc reading stuff is good for linux, but not for local runs on mac.

All of this is just used to make sure things are in a clean state when tests run and reduce flakes, so being a bit more robust seems like a good way to reduce our test flake noise.

else
echo "Warning: no tool available to find processes on port $1"
return
fi
if [ "$pids" != "" ]; then
kill "$pids"
kill $pids
echo "Stopped $pids."
fi
}
Expand Down