fix: update test script to work without lsof on CI#798
Merged
Conversation
jrvb-rl
changed the title
Use ss or fuser as fallbacks when lsof is not available, and warn gracefully if none are present. Co-Authored-By: Claude Opus 4.6 <[email protected]>
When lsof, ss, and fuser are all unavailable, parse /proc/net/tcp to find socket inodes listening on the target port, then scan /proc/*/fd/ to map inodes back to pids. Always available on Linux. Co-Authored-By: Claude Opus 4.6 <[email protected]>
james-rl
approved these changes
Jun 26, 2026
james-rl
left a comment
james-rl
left a comment
Contributor
There was a problem hiding this comment.
This looks ok. Maybe a bit overly defensive -- is there any point to trying lsof then using the fallbacks if we know lsof won't be available anyway?
| elif command -v fuser >/dev/null 2>&1; then | ||
| pids=$(fuser "$1/tcp" 2>/dev/null || echo "") | ||
| elif [ -d /proc/net ]; then | ||
| pids=$(find_pids_on_port_via_proc "$1") |
Contributor
Author
There was a problem hiding this comment.
I figured it was helpful to just try all of the reasonable things, to reduce the chances of this breaking in the future in different environments. Eg, the /proc reading stuff is good for linux, but not for local runs on mac.
All of this is just used to make sure things are in a clean state when tests run and reduce flakes, so being a bit more robust seems like a good way to reduce our test flake noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We had one test which worked locally but failed reliably in the github CI environment due to lsof not being installed. This fix should get the CI tests back to green.
kill_server_on_portwhenlsofis unavailable (e.g. on GitHub Actions runners)ss, thenfuser, then parse/proc/net/tcpdirectly as a final fallbackTest plan
lsof)./scripts/teststill works on macOS (useslsofpath)🤖 Generated with Claude Code