Set pipefail so that makes error code is propagated to the shell - #523
Merged
Merged
Conversation
Current pipe with tee swallows the error code if any from make.
matsl
force-pushed
the
fix_pipe_fail_not_propagated_as_error
branch
from
April 26, 2024 22:15
3fd775f to
4ed91bb
Compare
Collaborator
Author
No, |
rswgnu
approved these changes
Apr 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Current pipe with tee swallows the error code if any from make.
Why
The pipe to tee for both showing the output from make and storing it
for processing swallows the error code from make if it fails. Setting shell
to bash explicitly gets the
pipefailoption set which makes thepipe a whole fail if make fails.
Note
I noticed this incorrectness when looking at why the
rswbranch withthe hywiki did not fail since it should. (But it actually did fail. It was not
noticed since the compilation error was swallowed. This PR fixes this.)
There are some test commits before I got it right but I will squash them
on merge.