Skip to content

First attempt to support test coverage using the testcover package - #494

Merged
matsl merged 2 commits into
masterfrom
first-stab-at-coverage-support
Apr 1, 2024
Merged

matsl merged 2 commits into
masterfrom
first-stab-at-coverage-support

Conversation

@matsl

@matsl matsl commented Mar 22, 2024

Copy link
Copy Markdown
Collaborator

What

Add new test file for producing test coverage data. Uses the testcover
package.

Why

It is good to get some feedback how the tests are exercising the code
under test. This PR provides some convenience functions for running
code coverage interactively using the test suite or running it from
the make file.

Note

There seems to be some issues with stability of the tests for the
monitored file. Maybe because of the instrumentation. More experience
needs to be gathered here but it is a first attempt.

@matsl
matsl requested a review from rswgnu March 22, 2024 23:56
@matsl
matsl force-pushed the first-stab-at-coverage-support branch from 7a38a80 to e692a88 Compare March 31, 2024 21:05
@matsl
matsl force-pushed the first-stab-at-coverage-support branch from e692a88 to 4d73c57 Compare March 31, 2024 22:17
@matsl
matsl merged commit cf3d17b into master Apr 1, 2024
@matsl
matsl deleted the first-stab-at-coverage-support branch April 1, 2024 15:19
Comment thread ChangeLog

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we ever get any data out of this to see what our coverage looks like?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no. After implementing it, and looked at how the data looks, we have not used or tested it in practice on any file. It was so long ago, or my memory is so weak, I would have to look at it again to remember how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants