Add test for ibut:at-p on a remote path name - #489
Merged
Merged
Conversation
Collaborator
Author
|
@rswgnu Bob, I found another issue and documented it with a test case. Maybe the fix is just to check for pathname before email-address or we need to have a more advanced check for email-address that noticed if it is part of a remove file name. Leaving the fix for later in any case. |
rswgnu
approved these changes
Mar 21, 2024
matsl
force-pushed
the
add-test-for-ibut-at-on-remote-path
branch
from
March 21, 2024 16:14
d871a0a to
2df71a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add test for ibut:at-p on remote path names.
Why
There is a problem when point is in the email address part of the
remote name. It is identified as an email address so instead of
opening the remote file the email editor is opened.
The test case narrows it down a bit to ibut:at-p that is tested on
three positions in the remote file name. Before and after the email
portion and then on the email portion (which fails).
The test case is consequently configured as expected failed to
document the problem.