Merged
Conversation
yschimke
approved these changes
Jul 24, 2018
Member
yschimke
left a comment
yschimke
left a comment
There was a problem hiding this comment.
Is it worth considering a @nullable annotation on the field? I know that isn't really helpful vs on paramters and return methods.
Also a lot of methods on this class will still NPE when content is null. So seems like a specific patch here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are times when Frames are being released and the content field is null. This checks to see if the content is null and prevents a NullPointerException from being thrown.