Skip to content

[pull] main from microsoft:main#39

Merged
pull[bot] merged 1 commit intorrosajp:mainfrom
microsoft:main
Mar 21, 2025
Merged

[pull] main from microsoft:main#39
pull[bot] merged 1 commit intorrosajp:mainfrom
microsoft:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Mar 21, 2025 •
edited by sourcery-ai bot
Loading

See Commits and Changes for more details.

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Tests:

  • Adds a test case for removing custom mentions from activities using remove_mention_text function.

@pull pull bot added the ⤵️ pull label Mar 21, 2025
@pull pull bot merged commit e2015eb into rrosajp:main Mar 21, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Mar 21, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request introduces a new feature that allows the removal of custom mentions from an activity's text. The implementation involves adding a test case and modifying the remove_mention_text function to handle custom mentions.

Updated class diagram for TurnContext

classDiagram
  class TurnContext {
    +remove_mention_text(activity: Activity, identifier: str) : str
  }
  class Activity {
    +text: str
    +mentions: list
  }
  TurnContext -- Activity
Loading

File-Level Changes

Change Details Files
Added functionality to remove custom mentions from an activity's text.
  • Added a test case to verify the removal of custom mentions from an activity.
  • Modified the remove_mention_text function to handle custom mentions by extracting the mention text or name and removing it from the activity's text.
 libraries/botbuilder-core/tests/test_turn_context.py
libraries/botbuilder-core/botbuilder/core/turn_context.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

⤵️ pull

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@axelsrz