add: redis username to the settings#2121
Open
mertcanaliciaaron wants to merge 1 commit into
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2121 +/- ##
==========================================
+ Coverage 93.61% 93.91% +0.30%
==========================================
Files 28 30 +2
Lines 3760 4013 +253
==========================================
+ Hits 3520 3769 +249
- Misses 240 244 +4 ☔ View full report in Codecov by Sentry. |
Author
Collaborator
|
Could you make sure all tests pass so I can merge this in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have encounter the problem that we don't have username parameter, only password exists. The issue briefly raised in #1296 but I guess not solved.
I have implemented the username parameter to the settings. And fixed some tests.
Workaround: REDIS_URL parameter works fine even though we don't have username parameter.