Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

Properly synchronize CancellableLoop. #211

Open
okelepko wants to merge 2 commits into
base: obsolete/master
Choose a base branch
from
Open

Properly synchronize CancellableLoop. #211

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ff007
Properly synchronize CancellableLoop.
Jun 27, 2015
280c4a0
Properly synchronize CancellableLoop.
Jun 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Properly synchronize CancellableLoop. 
The write to the thread variable was guarded by a lock, but the reads were not. Also, operations in cancel and isRunning methods were not atomic. This could lead to visibility issues and data races (NPEs).
  • Loading branch information
okelepko committed Jun 27, 2015
commit 280c4a057652e8bdbb01a33081e19f49363458e8
2 changes: 1 addition & 1 deletion rosjava/src/main/java/org/ros/concurrent/CancellableLoop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public void run() {
} catch (InterruptedException e) {
handleInterruptedException(e);
} finally {
state.set(this);
state.set(FINISHED);
}
}

Expand Down