Port changes ament java: update how to export jars#186
Conversation
Signed-off-by: Jacob Perron <[email protected]>
Required for Dashing, but can be removed in Eloquent. Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
|
I don't recall if there was an issue leaving the old .sh and .bat templates, but if you have the bandwidth could you try and open a PR leaving them in? |
|
Or, I suppose we could just merge ros2-java/ament_java#15, since we don't care too much about being backwards compatible. |
|
@ivanpauno Can you add a commit to this PR that updates the repos file(s) to use the new |
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Sounds good! |
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Okay that worked, using ament_java main branch now. |
Starting to contribute back from https://github.com/osrf/ros2_java.
These are the first three commits in
osrf:galactic-develthat differ frommain.I think we will also need to merge ros2-java/ament_java#15 together with this.
Maybe we can first merge that PR without deleting the .sh and .bat templates, and then merge this one (to avoid breaking CI in the middle).