Conversation
For more information about the introduction of .dsv files, see - colcon/colcon-core#209 - ament/ament_package#89 Signed-off-by: Jacob Perron <[email protected]>
|
@esteve PTAL. I believe this change is needed so the proper environment is set, e.g. when a colcon workspace is sourced. |
|
@jacobperron do these supersede the |
Signed-off-by: Jacob Perron <[email protected]>
|
Yes, these supersede the old .bat and .sh templates. But, I realized that this change is not compatible with Dashing (as the DSV format was introduced in Eloquent). I suggest we create dashing branch before this is merged. |
|
@jacobperron done, I've created a |
| @@ -0,0 +1 @@ | |||
| prepend-non-duplicate;@JNI_LIB_ENV_VAR@;lib/jni | |||
There was a problem hiding this comment.
@jacobperron just one question, prepend-non-duplicate is supposed work for both Linux and Windows, right?
There was a problem hiding this comment.
Yes, I'm pretty sure it's supposed to work for both.
|
@jacobperron thanks! |
|
@jacobperron this is breaking master, so I had to revert it. The dashing branch is fairly big now, it'd make sense to merge it to master soon-ish and then target Eloquent/Foxy, otherwise it'll be more difficult to review the changes and keep track of all the work for both distros. |
2 participants
For more information about the introduction of .dsv files, see
I plan to use this change as part of the effort for getting ROS 2 Java working with
Dashingand Eloquent.