Closed
Conversation
Owner
|
Thanks for the patch - I am glad the project is helping you. I am not sure this change is correct though. I had added the utilities Logger for per instance logging, when the original code only used the System logger facilities - in order to change the filtering. I am going to need to review the best way to fix this - I probably did something wrong. I normally only use the utility loggers, but I was trying to stay as close as possible to the original JDK httpserver code. Are you certain your log4j is setup properly, and the System loggers are being redirected there? |
Owner
|
Thank you for the PR. After reviewing the apis your code change was correct, but I modified the PR slightly to remove the unused imports, and avoid white space changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This little patch solved the Log4J bridge problem for me. LogManager.getLogger(name) returns NULL, if the logger did not exist before - Logger.getLogger(name) does create an eventually not yet existing logger or returns the existing one.
Thank you for creating this project - it helps me preventing the bloat from full blown webserver frameworks.