Add custom Content-Range unit names. - #618
Closed
rmetzger wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Looks good! Here are some comments:
Thanks for the contribution :) |
Author
|
Thank you very much for the comments. Sadly, I don't have a lot of time these days. I'll see what I can do but I guess it takes at least two weeks till I find time to finish the pull request. Sorry :( |
ghost
assigned
Collaborator
|
No problem for the delay. The highest priority is the signed JCA as we can try to handle to rest ourselves later on if necessary |
Collaborator
|
Looking how simple the fix is, we'll just reimplement it ourselves so you don't have to provide a JCA. |
Contributor
|
Thanks for reporting this, I've updated the 2.2m1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains some code to allow the user to set a custom Content-Range name.
Typically, the HTTP/1.1 protocol expects the "bytes" keyword in a Content-Range, e.g.
Content-Range: bytes 0-32/128
Some Web-Frameworks like Dojo expect another Range-Unit. It is specified by the HTTP protocol to use custom units for Content-Ranges: http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.12
The documentation of Dojo says: http://dojotoolkit.org/reference-guide/1.7/dojox/data/JsonRestStore.html
"The server should respond with a Content-Range header to indicate how many items are being returned and how many total items exist:
Content-Range: items 0-24/66"