Skip to content

ExternsDiff: compute deps of TypeSynonyms properly #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zyla merged 3 commits into from
May 26, 2025
Merged

ExternsDiff: compute deps of TypeSynonyms properly #7

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e12b2f
Workaround (note: introduces another subtle bug)
zyla May 19, 2025
18f25e7
Remove workaround
zyla May 19, 2025
bfafba5
Proper fix
zyla May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove workaround
  • Loading branch information
@zyla
zyla committed May 19, 2025
commit 18f25e7f9e04369211f8b72f724df7834c0191be
5 changes: 0 additions & 5 deletions src/Language/PureScript/Make/ExternsDiff.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,11 +411,6 @@ externsTypeFixityToRef (P.ExternsTypeFixity _ _ n alias) =
externsDeclarationToRef :: ModuleName -> P.ExternsDeclaration -> Maybe RefWithDeps
externsDeclarationToRef moduleName = \case
P.EDType n t tk
| P.TypeSynonym <- tk ->
-- Type synonyms have two entries in externs: EDType and EDTypeSynonym.
-- Ignore the EDType entry, because later in the code we can't handle duplicate entries with the same Ref.
-- (TODO: is this legit? Will EDTypeSynonym contain all the deps of edTypeKind?)
Nothing
| P.isDictTypeName n -> Nothing
| otherwise -> Just (TypeRef n, typeDeps t <> typeKindDeps tk)
--
Expand Down