ExternsDiff: compute deps of TypeSynonyms properly#7
Merged
zyla merged 3 commits intorestaumaticfrom May 26, 2025
Merged
Conversation
jborkowski
approved these changes
May 26, 2025
kozak
approved these changes
May 26, 2025
kozak
reviewed
May 26, 2025
|
|
||
| -- | Returns refs as a tuple of four (added, removed, changed, unchanged). | ||
| splitRefs :: Ord r => Eq a => [a] -> [a] -> (a -> Maybe r) -> Tuple4 [] r | ||
| splitRefs :: forall ref a deps. Monoid deps => Ord ref => Eq a => [a] -> [a] -> (a -> Maybe (ref, deps)) -> Tuple4 [] (ref, deps) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where type synonym changes are incorrectly computed when diffing externs.
See https://github.com/zyla/purs-recompilation-repro for a reproducer of the bug.
Bug explanation: Externs files can have multiple entries with the same
Ref, but the code inExternsDiffassumed uniqueness. This led to buggy dependency graph construction.The fix is to merge duplicate entries.