Skip to content

Conversation

@github-roushan
Copy link

This prevents untracked build files from cluttering git status while keeping the module sources versioned.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-roushan
Copy link
Author

@sundb

@sundb sundb requested a review from YaacovHazan December 10, 2025 13:15
@sundb
Copy link
Collaborator

sundb commented Dec 11, 2025

maybe we can add a new .gitignore in modules dir

@github-roushan
Copy link
Author

@sundb . It's also about convenience. when i git clone the source code and do a build from the instructions i don't want git to show untracked anything other than lock files cause this causes issue changing branches and finding what needs to be staged. Since People usually download redis to build. i think its the right place

@sundb
Copy link
Collaborator

sundb commented Dec 11, 2025

@github-roushan i can't follow you, what i meant is like

# git status       
On branch unstable
Your branch is up to date with 'origin/unstable'.

You are currently bisecting, started from branch 'unstable'.
  (use "git bisect reset" to get back to the original branch)

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        modules/.gitignore

modules/.gitignore

rust*.tar.xz
redisbloom/src/
redisjson/src/
redistimeseries/src/
redisearch/src/

we still need to track the file in vectorset, so we can't use modules/*/src/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants