fix(Slider): center thumb on pressed location of the track#3821
Merged
arpitBhalla merged 2 commits intoreact-native-elements:nextfrom Sep 9, 2023
Merged
fix(Slider): center thumb on pressed location of the track#3821arpitBhalla merged 2 commits intoreact-native-elements:nextfrom
arpitBhalla merged 2 commits intoreact-native-elements:nextfrom
Conversation
✅ Deploy Preview for react-native-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
@arpitBhalla anything I can do on my end to get this merged? If you feel it's good to go, are you able to merge it? |
Member
|
Hey @krosenberg can you ping me on discord |
Codecov Report
@@ Coverage Diff @@
## next #3821 +/- ##
==========================================
- Coverage 79.91% 79.69% -0.22%
==========================================
Files 87 87
Lines 1837 1842 +5
Branches 809 811 +2
==========================================
Hits 1468 1468
- Misses 364 369 +5
Partials 5 5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
allowTouchTrackis set totrue, I expect the center of the thumb to be positioned over my tapped location. Currently, it aligns to the left of the thumb instead of the center.allowTouchTrackisfalse, I can tap anywhere inside the thumb and the thumb position does not change until I begin dragging. But ifallowTouchTrackistrue, the thumb will immediately left-align itself when I tap anywhere inside the thumb. I expect this behavior of tapping and dragging the thumb to be consistent no matter what the value ofallowTouchTrackis.You can see both issues in the video below. You can reproduce the issue in the Slider examples in the example app.
rneui_slider_before.mov
rneui_slider_after.mov
Type of change
How Has This Been Tested?
I've manually tested the changed behavior using the example app on an iOS iPhone 14 simulator.
exampleappChecklist
yarn docs-build-apiAdditional context
N/A