Skip to content

fix(Divider): borderBottomWidth error when the width is a percentage #3804

Merged
arpitBhalla merged 2 commits intoreact-native-elements:nextfrom
phankietit:fix/divider/border_bottom_width
Jun 9, 2023
Merged

fix(Divider): borderBottomWidth error when the width is a percentage #3804
arpitBhalla merged 2 commits intoreact-native-elements:nextfrom
phankietit:fix/divider/border_bottom_width

Conversation

@phankietit
Copy link
Copy Markdown
Contributor

@phankietit phankietit commented Jun 9, 2023

  • Error when the width is a percentage. Ex: 90%

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

phankietit added 2 commits June 9, 2023 20:55
@phankietit
check render if width is number
e2e395b 
- Error when the width is a percentage. Ex: 90%
@phankietit
add comment
341134b
@netlify
Copy link
Copy Markdown

netlify bot commented Jun 9, 2023 •
edited
Loading

✅ Deploy Preview for react-native-elements ready!

Name Link
🔨 Latest commit 341134b
🔍 Latest deploy log https://app.netlify.com/sites/react-native-elements/deploys/6483304f161d5500085d0a92
😎 Deploy Preview https://deploy-preview-3804--react-native-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@phankietit phankietit changed the title fix: divider borderBottomWidth error when the width is a percentage fix(Divider): borderBottomWidth error when the width is a percentage Jun 9, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 9, 2023

Codecov Report

Merging #3804 (e76337d) into next (3c6eac2) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e76337d differs from pull request most recent head 341134b. Consider uploading reports for the commit 341134b to get more accurate results

@@           Coverage Diff           @@
##             next    #3804   +/-   ##
=======================================
  Coverage   79.85%   79.85%           
=======================================
  Files          87       87           
  Lines        1822     1822           
  Branches      804      804           
=======================================
  Hits         1455     1455           
  Misses        362      362           
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/Divider/Divider.tsx 92.30% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla merged commit 5a48d33 into react-native-elements:next Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phankietit @arpitBhalla