feat(Input): Ability to specify an Input ErrorComponent#3759
Merged
arpitBhalla merged 4 commits intoreact-native-elements:nextfrom Jun 17, 2023
Merged
Conversation
I have this patched locally on `rc.7` mainly so that I can animate the text in and out when shown. Here’s how I’m using this enhancement is by animating the error message in and out, which was not possible with the current `errorMessage` implementation.
Codecov Report
@@ Coverage Diff @@
## next #3759 +/- ##
==========================================
+ Coverage 79.85% 79.86% +0.01%
==========================================
Files 87 87
Lines 1822 1823 +1
Branches 804 813 +9
==========================================
+ Hits 1455 1456 +1
Misses 362 362
Partials 5 5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
✅ Deploy Preview for react-native-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…rt/react-native-elements into mrickert/input-error-component
arpitBhalla
approved these changes
Jun 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I have this patched locally on
rc.7mainly so that I can animate the text in and out when shown.I included a component in the example that shows how to animate error messages, which was not possible with the current
errorMessageimplementation.Fixes n/a
Type of change
How Has This Been Tested?
exampleappChecklist
yarn docs-build-apiAdditional context
I had trouble committing because of the pre-commit hook.
yarn lint-stagedwas failing for me so skipped the hooks. If this doesn't build/run on CI, please let me know what I can do to get it passing.Locally, with these changes,
yarn && yarn lint && yarn typescript && yarn testall run locally.