Skip to content

feat(theming): add spacing to theme#3495

Merged
arpitBhalla merged 3 commits intoreact-native-elements:nextfrom
arpitBhalla:rne-theme-docs
May 9, 2022
Merged

feat(theming): add spacing to theme#3495
arpitBhalla merged 3 commits intoreact-native-elements:nextfrom
arpitBhalla:rne-theme-docs

Conversation

@arpitBhalla
Copy link
Copy Markdown
Member

@arpitBhalla arpitBhalla commented May 3, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@mauris
Copy link
Copy Markdown

mauris commented May 5, 2022

@arpitBhalla there are failing tests related to changes made to makeStyles. Possibly help to fix the code or update the tests?

there are also conflicts with the target branch, appreciate that you resolve the conflicts (:

@arpitBhalla
Copy link
Copy Markdown
Member Author

arpitBhalla commented May 5, 2022 •
edited
Loading

@mauris I appreciate your keenness to review, but this PR is in progress, If you want to contribute, could you please pick any open issue, that would be much helpful.

@codecov
Copy link
Copy Markdown

codecov bot commented May 9, 2022

Codecov Report

Merging #3495 (8ae3b58) into next (47b8932) will decrease coverage by 0.12%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##             next    #3495      +/-   ##
==========================================
- Coverage   79.48%   79.36%   -0.13%     
==========================================
  Files          87       87              
  Lines        1779     1783       +4     
  Branches      773      772       -1     
==========================================
+ Hits         1414     1415       +1     
- Misses        359      362       +3     
  Partials        6        6
Impacted Files Coverage Δ
packages/themed/src/config/ThemeProvider.tsx 78.57% <58.33%> (-8.93%) ⬇️
packages/themed/src/config/makeStyles.ts 100.00% <100.00%> (+16.66%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit f71f16e into react-native-elements:next May 9, 2022
@arpitBhalla arpitBhalla deleted the rne-theme-docs branch May 9, 2022 19:21
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@arpitBhalla
feat(theming): add spacing to theme (#3495)
ca917b1 
* update

* update tests
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@arpitBhalla
feat(theming): add spacing to theme (#3495)
5f88f50 
* update

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: New Feature 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arpitBhalla @mauris