Skip to content

fix(Icon): raised ios shadow issue#3491

Merged
arpitBhalla merged 3 commits intoreact-native-elements:nextfrom
kedar09:iconRaised_iOS
May 9, 2022
Merged

fix(Icon): raised ios shadow issue#3491
arpitBhalla merged 3 commits intoreact-native-elements:nextfrom
kedar09:iconRaised_iOS

Conversation

@kedar09
Copy link
Copy Markdown
Contributor

@kedar09 kedar09 commented May 3, 2022

Fixes # (issue)
#3058

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • My changes generate no new warnings

Additional context

@codecov
Copy link
Copy Markdown

codecov bot commented May 3, 2022

Codecov Report

Merging #3491 (ff2ee80) into next (52d2f27) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ff2ee80 differs from pull request most recent head 54dddad. Consider uploading reports for the commit 54dddad to get more accurate results

@@            Coverage Diff             @@
##             next    #3491      +/-   ##
==========================================
+ Coverage   79.45%   79.47%   +0.01%     
==========================================
  Files          87       87              
  Lines        1777     1778       +1     
  Branches      771      772       +1     
==========================================
+ Hits         1412     1413       +1     
  Misses        359      359              
  Partials        6        6              
Impacted Files Coverage Δ
packages/base/src/Icon/Icon.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla changed the title Icon - raised ios shadow issue fix(Icon): raised ios shadow issue May 3, 2022
@arpitBhalla arpitBhalla merged commit 6224af4 into react-native-elements:next May 9, 2022
github-actions bot pushed a commit that referenced this pull request May 9, 2022
github-actions bot pushed a commit that referenced this pull request May 9, 2022
@kedar09 kedar09 deleted the iconRaised_iOS branch May 9, 2022 19:16
@arpitBhalla arpitBhalla linked an issue May 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon raised border problem on iOS

2 participants