Skip to content

fix(themeColors): add support for dark mode#3078

Merged
arpitBhalla merged 21 commits intoreact-native-elements:nextfrom
arpitBhalla:issue-dark-theme
Jan 27, 2022
Merged

fix(themeColors): add support for dark mode#3078
arpitBhalla merged 21 commits intoreact-native-elements:nextfrom
arpitBhalla:issue-dark-theme

Conversation

@arpitBhalla
Copy link
Copy Markdown
Member

@arpitBhalla arpitBhalla commented Jun 11, 2021

Fixes #3069
Fixes #3070
Fixes #3068

@arpitBhalla arpitBhalla changed the title [ListItem] Subtitle dark theme text [Theme] Dark theme support Jun 11, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2021

Codecov Report

Merging #3078 (114779c) into next (498acb4) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 114779c differs from pull request most recent head 6d1c1f6. Consider uploading reports for the commit 6d1c1f6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next    #3078      +/-   ##
==========================================
- Coverage   79.95%   79.93%   -0.02%     
==========================================
  Files          88       88              
  Lines        1661     1660       -1     
  Branches      730      729       -1     
==========================================
- Hits         1328     1327       -1     
  Misses        328      328              
  Partials        5        5              
Impacted Files Coverage Δ
packages/base/src/CheckBox/CheckBox.tsx 93.54% <ø> (-0.21%) ⬇️
packages/base/src/ListItem/ListItem.Subtitle.tsx 100.00% <ø> (ø)
packages/base/src/Overlay/Overlay.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498acb4...6d1c1f6. Read the comment docs.

@arpitBhalla arpitBhalla changed the title [Theme] Dark theme support [theme] Dark theme support Jun 18, 2021
@arpitBhalla arpitBhalla changed the title [theme] Dark theme support [theme] Add dark colors Jun 29, 2021
@arpitBhalla arpitBhalla changed the title [theme] Add dark colors [theme] 🐛 Add dark colors Jun 30, 2021
@flyingcircle
Copy link
Copy Markdown
Collaborator

conflicts need to be fixed.

@arpitBhalla arpitBhalla changed the title [theme] 🐛 Add dark colors [theme] Add dark colors Jul 15, 2021
@arpitBhalla arpitBhalla reopened this Jan 25, 2022
@arpitBhalla arpitBhalla changed the title [theme] Add dark colors fix(themeColors): add support for dark mode Jan 25, 2022
@arpitBhalla arpitBhalla merged commit 8a7743e into react-native-elements:next Jan 27, 2022
@arpitBhalla arpitBhalla deleted the issue-dark-theme branch January 27, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CheckBox colors does not match dark theme ListItemSubtitle is invisible in dark theme Overlay background color does not inherit theme's color.

5 participants