Skip to content

📦 NEW: Add strict variables in tsconfig#535

Open
meerhamzadev wants to merge 1 commit intoreact-figma:masterfrom
meerhamzadev:tsconfig-strict
Open

📦 NEW: Add strict variables in tsconfig#535
meerhamzadev wants to merge 1 commit intoreact-figma:masterfrom
meerhamzadev:tsconfig-strict

Conversation

@meerhamzadev
Copy link

@meerhamzadev meerhamzadev commented Oct 3, 2022

Hello, this PR is solving Issue #128. In this PR, I added different strict mode variables like:
✅ noImplicitAny
✅ noImplicitThis
✅ strictNullChecks
✅ strictPropertyInitialization
✅ alwaysStrict

@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-figma ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 6:46PM (UTC)

@meerhamzadev
Copy link
Author

@ilyalesik I opened the PR around eight days ago. Kindly have a look at it.

@ilyalesik
Copy link
Member

@meerhamzadev hey! CI/CD fails on test and typescript (npm run test and npm run tsc commands), please take a look

@meerhamzadev
Copy link
Author

Hey @ilyalesik, This is due to the strict variables, I added in the tsconfig file. The code is throwing warnings due to strict mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants