Update GCE labels flag to google-vm-labels#347
Merged
HarrisonWAffel merged 1 commit intorancher:masterfrom Jul 3, 2025
Merged
Conversation
HarrisonWAffel
force-pushed
the
update-gce-labels
branch
from
75ae458 to
95e47e7
Compare
Author
|
Good call out @jiaqiluo, yes this driver has not been released yet and is slated for 2.12 |
snasovich
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#49681
This is a minor change to the
google-labelsflag that renames it togoogle-vm-labels.This is needed to properly integrate the driver with the Rancher UI.
google-labelsis translated to simplylabelsin the generated machine config, and the UI expects that to refer to a k8s label. Due to this, the UI team cannot support the GCE specific labels field without more comprehensive changes to how they handle the UI for all drivers.