Merged
Conversation
brenogazzola
reviewed
Mar 4, 2022
Contributor
Author
|
Assuming all else is ok with these changes, I will wait till #79 is merged and integrate change with this, then open the PR. |
Collaborator
|
It's merged. |
Contributor
Author
|
Great, I will get on this today |
Minor changes to language/readability and an extra note about migrating webpack configuration before deleting
Collaborator
|
@stevegeek Do you still want to add anything or can I merge this? |
Contributor
Author
|
@brenogazzola Feel free to merge, Im happy with these changes for now, if I notice anything else in future I will open a new PR. |
Collaborator
|
Great! Thanks a lot for helping with the guide. |
Contributor
Author
|
@brenogazzola you are welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all, here are some suggested edits and additions for the upgrade documentation.
I decided on these by running through the steps starting with a fresh Rails app (generated with 6.1 then upgraded to 7)
I started with
webpackerandsass-railsand tested the original steps. From that I noted something extra in relation to the default module resolution in webpacker and added a section about it.I then also ran through a setup where CSS was built by webpacker (
extract_css: true). The additional instructions didn't seem to me to warrant a separate guide so I simply modified the main one.Happy to add/remove/modify anything as needed!
(Note the comment I made on the #76 about an error when removing webpacker was my bad)