fix(slider): onValueCommit not called when range is narrowed to single value #3829
Open
zaewc wants to merge 2 commits intoradix-ui:mainfrom
Open
fix(slider): onValueCommit not called when range is narrowed to single value #3829zaewc wants to merge 2 commits intoradix-ui:mainfrom
zaewc wants to merge 2 commits intoradix-ui:mainfrom
Conversation
Covers the regression where narrowing a range to a single value from the right thumb fails to fire onValueCommit due to index remapping after sort.
🦋 Changeset detectedLatest commit: 610e5b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3698
When dragging the right thumb of a range slider to overlap the left thumb (e.g.
[105, 107]→[105, 105]),onValueCommitwas never fired.handleSlideEndcompared individual thumb values usingvalueIndexToChangeRef.currentas the index.However, this index is remapped to the sorted position inside
updateValueswhen two thumbs land on thesame value,
indexOfreturns0for both. SohandleSlideEndended up comparing the left thumb's valueagainst itself and concluded nothing had changed.
The fix compares the full value arrays using
String(values) !== String(prevValues), which is the sameapproach already used inside
updateValues.